Skip to content

feat(enrichment): detect Pinecone and Tavily API keys in secret-scan#3273

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bohdansolovie:feat/secret-scan-pinecone-tavily
Jul 5, 2026
Merged

feat(enrichment): detect Pinecone and Tavily API keys in secret-scan#3273
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bohdansolovie:feat/secret-scan-pinecone-tavily

Conversation

@bohdansolovie

@bohdansolovie bohdansolovie commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Motivation

Pinecone and Tavily credentials are commonly leaked in AI agent configs and env files. The secret-scan analyzer covers many AI/SaaS tokens but missed these documented formats.

Test plan

  • Pinecone — positive match, short label/secret negatives, identifier-continuation negative
  • Tavily — positive match, truncated negative, _suffix continuation negative
  • Fragment-based fixtures (no contiguous fake secrets in source)
  • Full secret-scan.test.ts suite passes (66 tests)

Made with Cursor

@bohdansolovie
bohdansolovie requested a review from JSONbored as a code owner July 5, 2026 00:16
@superagent-security superagent-security Bot added the contributor:flagged Contributor flagged for review by trust analysis. label Jul 5, 2026
@superagent-security

superagent-security Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

@superagent-security

superagent-security Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 00:37:19 UTC

2 files · 1 AI reviewer · no blockers · readiness 73/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This change adds two focused secret-scan rules and covers the positive, malformed, and continuation cases described in the PR. The regexes are consistent with the surrounding high-confidence rule style, and the tests exercise the actual scanPatch path rather than fabricated analyzer internals. I do not see a reachable correctness break in the visible diff.

Nits — 3 non-blocking
  • nit: review-enrichment/test/secret-scan.test.ts:569 only exercises the minimum Tavily body length, so it would be useful to include a representative documented-length Tavily key fixture as well as the boundary case.
  • review-enrichment/test/secret-scan.test.ts:569: add one Tavily positive at the documented normal body length, keeping the current 16-char minimum case if 16 is intentionally accepted.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 182 registered-repo PR(s), 102 merged, 9 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bohdansolovie; Gittensor profile; 182 PR(s), 9 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: bohdansolovie
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 182 PR(s), 9 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

loopover-orb[bot]
loopover-orb Bot previously approved these changes Jul 5, 2026
View reviewed changes

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@bohdansolovie @cursoragent
feat(enrichment): detect Pinecone and Tavily API keys in secret-scan
3181cbb 
Add high-confidence pcsk_{label}_{secret} and tvly- token patterns with
identifier-continuation tail guards and dedicated regression tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bohdansolovie
bohdansolovie force-pushed the feat/secret-scan-pinecone-tavily branch from ad840e8 to 3181cbb Compare July 5, 2026 00:38
@jimcody1995 jimcody1995 mentioned this pull request Jul 5, 2026
Closed
24 tasks
loopover-orb[bot]
loopover-orb Bot approved these changes Jul 5, 2026
View reviewed changes

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 4deee3e into JSONbored:main Jul 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loopover-orb loopover-orb[bot] loopover-orb[bot] approved these changes
@JSONbored JSONbored Awaiting requested review from JSONbored JSONbored is a code owner

Assignees

@bohdansolovie bohdansolovie

Labels

contributor:flagged Contributor flagged for review by trust analysis. gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bohdansolovie